-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update help text alignment in CheckboxControl #60787
Changes from 4 commits
599a832
456b9de
95f19f9
db42921
55e5dc7
8a7f550
8f08d50
92d2783
6c41d46
be6becb
e3a1640
b20d045
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,20 @@ | |
@include break-small() { | ||
--checkbox-input-size: 20px; | ||
} | ||
|
||
.components-base-control__help { | ||
margin-left: calc(var(--checkbox-input-size) + #{$grid-unit-15}); | ||
} | ||
|
||
.components-base-control__field { | ||
// Emsure label doesn't wrap beneath checkbox | ||
display: flex; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can avoid reaching into BaseControl internals here by wrapping our elements in an |
||
|
||
.components-checkbox-control__label { | ||
// Ensure label is aligned with checkbox along X axis | ||
line-height: var(--checkbox-input-size); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's move this part out of the |
||
} | ||
|
||
.components-checkbox-control__input[type="checkbox"] { | ||
|
@@ -50,9 +64,10 @@ | |
.components-checkbox-control__input-container { | ||
position: relative; | ||
display: inline-block; | ||
margin-right: 12px; | ||
margin-right: $grid-unit-15; | ||
vertical-align: middle; | ||
width: var(--checkbox-input-size); | ||
height: var(--checkbox-input-size); | ||
aspect-ratio: 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was, but moving to a HStack seems to have made it redundant :) |
||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inevitable at the moment, but raised as an issue at #60836.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw the linked issue. It probably wouldn't be as flexible, but could checkbox control do something like this to indent the text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good one! Yes that could work in this instance, with a
display: inline-block
to account for when the help text is long enough to wrap.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the benefit to doing this? Feel free to push any changes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. The point is that we shouldn't be using selectors from other components, because they aren't guaranteed to be stable. Ideally they would all be obfuscated/randomized so they aren't even available outside the original component.
I'll try it out and push the changes 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 8f08d50