ApiFetch: Script module #60952
Draft
ApiFetch: Script module #60952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
force-pushed
the
add/module-compatible-api-fetch
branch
from
c017fd8
to
9c47e04
Compare
|
Size Change: -36.5 kB (-2.05%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
sirreal
force-pushed
the
add/module-compatible-api-fetch
branch
from
b509d08
to
2a33146
Compare
sirreal
force-pushed
the
add/module-compatible-api-fetch
branch
from
2a33146
to
7447563
Compare
sirreal
commented
Jun 21, 2024
lib/experimental/script-modules.php
Outdated
| wp_register_script_module( '@wordpress/api-fetch', gutenberg_url( 'build/script-modules/apiFetch.min.js' ) ); | ||
|
|
||
| // add_filter( | ||
| // 'scriptmoduleconfig_@wordpress/api-fetch', |
There was a problem hiding this comment.
This should be restored with the correct filter name:
gutenberg/lib/experimental/script-modules.php
Line 246 in 5738e9b
packages/api-fetch/src/wp-module.js
Outdated
|
|
||
| if ( typeof document !== 'undefined' ) { | ||
| const el = document.getElementById( | ||
| 'wp-scriptmodule-data_@wordpress/api-fetch' |
There was a problem hiding this comment.
This should be updated with the correct ID:
gutenberg/lib/experimental/script-modules.php
Line 284 in 5738e9b
This was referenced Sep 4, 2024
sirreal
force-pushed
the
add/module-compatible-api-fetch
branch
from
7447563
to
385ebb6
Compare
|
Yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast