Refactor inserter tabs #61048
Closed
Refactor inserter tabs #61048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +16 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
force-pushed
the
try/refactor-inserter-tabs
branch
from
96fb85a
to
02b0efb
Compare
jeryj
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
scruffian
force-pushed
the
try/no-autoclose-inserter
branch
from
bf8f690
to
9a1ec9c
Compare
scruffian
reviewed
Apr 25, 2024
| forwardRef, | ||
| useState, | ||
| useCallback, | ||
| useMemo, |
There was a problem hiding this comment.
I wonder if its ok to remove all the useMemos
There was a problem hiding this comment.
I'm not sure -- let's performance test it and see if it's the same or better without it, and then we can add it back in if we need to. Before it was especially necessary because everything was running everything on mount. Now it doesn't build all at once but each tab content gets rendered when it's clicked.
There was a problem hiding this comment.
I tried a memoized and unmemoized version of the blocks tab, and memoizing was faster by our specs:
memo:
│ inserterOpen │ '15.22 ms' │
│ inserterSearch │ '4.79 ms' │
│ inserterHover │ '1.83 ms' │
no memo
│ inserterOpen │ '15.76 ms' │
│ inserterSearch │ '5.56 ms' │
│ inserterHover │ '1.89 ms' │
scruffian
force-pushed
the
try/refactor-inserter-tabs
branch
from
02b0efb
to
9a054a3
Compare
jeryj
commented
Apr 25, 2024
Comment on lines
56
to
62
| <Button | ||
| className="block-editor-sidebar__close-button" | ||
| icon={ closeSmall } | ||
| label={ __( 'Close block inserter' ) } | ||
| onClick={ () => setIsInserterOpened( false ) } | ||
| size="compact" | ||
| /> |
There was a problem hiding this comment.
It feels weird to put this button inside of the InserterTabs component. I think we should move it up into the menu.js or leave it as it was. The button was working, it just needed a boosted z-index to be clickable.
There was a problem hiding this comment.
I did this so it matches with the ListView
|
Closed in favor of #61108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast