Editor: Unify the BlockContextualToolbar component between post and site editors #61104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
General Interface
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -700 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Apr 25, 2024
| isCollapsed, | ||
| toggleCollapse, | ||
| } ) { | ||
| const blockToolbarRef = useRef(); |
There was a problem hiding this comment.
Good catch. The ref had no actual use.
Mamaduka
reviewed
Apr 25, 2024
| isCollapsed={ isBlockToolsCollapsed } | ||
| blockSelectionStart={ blockSelectionStart } | ||
| toggleCollapse={ handleToggleCollapse } | ||
| onToggle={ handleToggleCollapse } |
There was a problem hiding this comment.
We can pass setIsBlockToolsCollapsed here (like in edit-site) and remove handleToggleCollapse.
Mamaduka
approved these changes
Apr 25, 2024
jeryj
approved these changes
Apr 25, 2024
| const { DocumentTools, PostViewLink, PreviewDropdown, PinnedItems, MoreMenu } = | ||
| unlock( editorPrivateApis ); | ||
| const { | ||
| BlockContextualToolbar, |
There was a problem hiding this comment.
I know this is what I called it, but I'm not convinced of the name BlockContextualToolbar. It's the <BlockToolbar />, but allows it to be collapsed. Maybe it should be changed to <CollapsableBlockToolbar />? Without the collapsing functionality, it's just a block toolbar.
There was a problem hiding this comment.
Sure works for me. It's going to be an internal component anyway, once we complete the unification of edit-post and edit-site, a lot of these private APIs won't be exported anymore.
youknowriad
force-pushed
the
update/unify-block-contextual-toolbar
branch
from
a8b8911
to
45a14bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
We're in a middle of an effort to merge the post and site editors under the @wordpress/editor abstraction. As part of this, this PR unifies the BlockContextualToolbar component between the post and site editors.
Testing Instructions
1- Enable Top Toolbar in both post and site editors
2- Ensure that it looks and behaves the same as trunk.
I did make some CSS shuffling so it would be good to check for potential CSS regressions.