Upgrade React to v18.3 #61202
Merged
Upgrade React to v18.3 #61202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -55 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
This comment was marked as outdated.
This comment was marked as outdated.
|
@Mamaduka that change in the test makes sense. I think we were supposed to do in previous versions as well. Maybe it's more consistent now. |
|
There's no warning when a test uses The issue seems to affect the user-event library, which I thought was a wrapper around Update: Fixed the issue by downgrading RTL to v14.3; this version made it compatible with the new |
Mamaduka
force-pushed
the
update/react-18-3
branch
from
2a490dc
to
d1d3b2f
Compare
Mamaduka
requested review from
ajitbohra,
gziolo,
ntwb and
nerrad
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I noticed that some of the React Native code still uses the now deprecated cc @WordPress/native-mobile |
Mamaduka
added
the
Needs Dev Note
@Mamaduka Yes, if you want to handle replacing the remaining If addressing in this PR, for function components we can continue to add the Opening it up to the rest of the native-mobile team if they have further thoughts/feedback. (We are not planning to cut a Gutenberg Mobile release until May 9, so we should have plenty of time to test.) |
|
Sounds good, @derekblank! FYI, the Let's handle the |
TIL. 👍
Sounds good. I created an issue to keep track: wordpress-mobile/gutenberg-mobile#6840 |
|
Can I get an ✅ to land this upgrade? |
tyxla
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
With the native ones tracked and addressed separately, this looks good!
I took a look at the release notes and didn't spot any concerning bits that we need to account for. Also, smoke testing went well. Let's go for it!
Thanks for working on it @Mamaduka 🚀
Merged
2 tasks
|
I think this one needs a manual backport to WP Core. |
|
@youknowriad, do you remember when we last did the manual update in core? I assume I can base the new branch on that. |
|
@Mamaduka I don't, It may have been done at the same time as the package update but I believe it involves updating the package.json and potentially some version numbers in script-loader.php and nothing more. |
|
@youknowriad, I found the commit for React 18.2 and will use it as a template. |
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates React to 18.3.1. in preparation for the React 19 release.
See the full changelog - https://github.com/facebook/react/blob/main/CHANGELOG.md#1831-april-26-2024.
Testing Instructions
Smoke test the editors. CI checks should be green.