Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint: Restore curly rule with prettier #61204

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Eslint: Restore curly rule with prettier #61204

merged 2 commits into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. Eslint: Restore curly rule when using prettier 

    The `curly` eslint rule was disabled when using prettier. Some
configurations of the rule may conflict with prettier's autoformatting,
but the `all` option used in @wordpress/eslint-plugin does not.

This aligns with the WordPress JavaScript Standards:

> `if`, `else`, `for`, `while`, and `try` blocks should always use
> braces, and always go on multiple lines.

- WordPress JavaScript Standards: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/#blocks-and-curly-braces
- `curly` rule description: https://eslint.org/docs/latest/rules/curly#rule-details

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    @sirreal @gziolo
    @swissspidy @youknowriad
    5 people committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4c5e5b0 View commit details
    Browse the repository at this point in the history

  2. Apply eslint autofix for curly rule violations

    @sirreal
    sirreal committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f6c42d6 View commit details
    Browse the repository at this point in the history