Fix inconsistent complementary header styles #61331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -277 B (-0.02%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 930e082. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8980435318
|
stokesman
reviewed
May 2, 2024
packages/interface/src/components/complementary-area-header/style.scss
Outdated
Show resolved
Hide resolved
jasmussen
approved these changes
May 3, 2024
t-hamano
reviewed
May 3, 2024
packages/edit-site/src/components/sidebar-edit-mode/global-styles-sidebar.js
Outdated
Show resolved
Hide resolved
jasmussen
reviewed
May 7, 2024
packages/edit-site/src/components/sidebar-edit-mode/global-styles-sidebar.js
Show resolved
Hide resolved
t-hamano
approved these changes
May 7, 2024
There was a problem hiding this comment.
LGTM! This PR appears to be working as expected. It also works with a plugin sidebar.
Code to test
function MyPluginSidebar() {
return React.createElement(
wp.editor.PluginSidebar,
{
name: 'my-sidebar',
icon: 'admin-post',
title: 'My sidebar title',
},
React.createElement( wp.components.PanelBody, {}, 'My sidebar content' )
);
}
wp.plugins.registerPlugin( 'plugin-sidebar-test', { render: MyPluginSidebar } );
tyxla
approved these changes
May 7, 2024
packages/interface/src/components/complementary-area-header/style.scss
Outdated
Show resolved
Hide resolved
This reverts commit e231cb5.
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
richtabor
force-pushed
the
try/global-styles-header-fixes
branch
from
48160d0
to
8d3941d
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reduces displacement of close icon, inconsistent border/tab combinations (fixes #61055) and uses the same icon sizes as in other sidebars.
One part of this is an alternative approach to #61318.
Testing Instructions
Visual
Before
CleanShot.2024-05-02.at.12.09.48.mp4
After
CleanShot.2024-05-02.at.12.09.04.mp4