Make the navigateRegions shortcuts work from anywhere. #6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
the
[Focus] Accessibility (a11y)
This was referenced Apr 12, 2018
|
This is very similar to #6149 and just adds the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the prop
bindGlobalto the navigable regions keyboard shortcuts (Ctrl+backtick) to make them work also from the contenteditable areas, input fields, and textareas.Keyboard users would greatly benefit from being able to jump through the main editor region at any moment. For example, when editing a paragraph they can now jump to the sidebar and enable the drop cap. This wasn't possible before because tabbing away from the paragraph selected another block.
Reference:
https://craig.is/killing/mice#api.bind.text-fields
https://github.com/ccampbell/mousetrap/tree/master/plugins/global-bind
Fixes #5847