Move sidebar close buttons to left side #61514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +61 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Marked as draft as this is exploratory. Thanks. |
|
I appreciate the effort, but I do think we should do more explorations. This introduces a non-standard implementation for close button placement, across the majority of web-based applications. It also results in some close icons placed on the left, while others are on the right—an inconsistency that adds cognitive weight for the user. I'd like to explore alternatives that results in a better experience for everyone. |
|
I agree, the left-positioned close button is visually unexpected and overly prominent. If the close button is required, which seems to be the case given the toggle button is not part of the panel it controls, then I struggle to see a solution that doesn't involve introducing some kind of panel header: 
This would allow the close button to be the element that receives initial focus, respecting the toggle behavior for keyboard users. What other options do we have? |
|
@jameskoster - I can do a PR that implements the panel header design you posted.
It's OK if the focus button doesn't have focus initially. It can be skipped over when focus is sent to it from opening the button. The issue is that the focus order doesn't match visual order when using the Tab key. |
|
I also think we should consider alternative explorations before committing to this. This simple change would impact how all users interact with the editor, so we should be confident this is the best solution before introducing such a change. |
|
Added before & after screenshots to the description. |
|
My understanding is that we are going to try this approach: #61837 so I'll close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes accessibility issues where focus order must match visual order, and also not be between the tabs and tab panel.
Why?
Accessibility.
How?
Moves Close button to before the tabs/removes flex order.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast