Placeholder: Tweak placeholder style #61590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: -156 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
tweak/placeholder-layout
branch
from
967e73e
to
4a6cb20
Compare
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
May 14, 2024
|
@jasmussen Thanks for the review!
Does this refer to editor.scss or style.scss? Regarding |
|
I mean the editor.scss file — and this PR is a great step forward to reducing those pieces. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41961
Related to #59275
What?
This PR adjusts the placeholder layout for RSS and Embed blocks.
With this PR, the following two things apply:
Why?
To make placeholder styles more consistent.
How?
This PR changes the gap and margin of the Placeholder component itself, but this component already has a flex layout applied, so the impact on developers should be minor.
Testing Instructions
Note
You may notice that when you paste text into a text field, unintended behavior occurs. This is a known issue and has been reported on #61377.
Screenshots or screencast
Desktop
Mobile