Zoom Out: The patterns tab behind a new experiment. #61601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.08 kB (+0.06%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
In another channel @scruffian and I thought it should be better to create an experiment rather than having to use the global styles browser to trigger zoom out mode, that is until the assembly experience is ready for prime time. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/editor-settings.php ❔ lib/experiments-page.php |
scruffian
changed the title
draganescu
reviewed
May 20, 2024
draganescu
approved these changes
May 20, 2024
Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
|
Flaky tests detected in bc48a5c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9161185123
|
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Zoom Out: Remove from the patterns tab until we're ready * hide the pattern tab zoom out behind an experiment * Update lib/experiments-page.php Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> --------- Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In trunk we zoom out the canvas when you open the patterns tab. This PR hides that behaviour behind an experimental flag.
Why?
I don't think the current zoom out experience is good enough to be useful yet, so we should remove this from the next version of Gutenberg until it's ready.
How?
Put the hook behind an experimental flag.
Testing Instructions
Note
Zoom out can still be accessed from Global Styles > Browse Styles.