Make sure to replace all instances of :where(body) instead of just …
#61602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @simom, @rxbracho. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +61 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
May 13, 2024
There was a problem hiding this comment.
Oh, good catch! This is testing nicely for me.
With TT4 theme applied you can see the difference quite clearly:
| Before | After |
|---|---|
 |
 |
It'd be great to get this fix in, so no need to hold up landing, but would it be worth updating the tests to include a couple examples for this replacement behaviour?
|
I added one test, reasoning that checking for multiple instances of |
tellthemachines
added
the
props-bot
github-actions
bot
removed
the
props-bot
|
Thanks for that, the added test looks good to me! |
Mamaduka
approved these changes
May 13, 2024
Mamaduka
added
the
Backport to Gutenberg Minor Release
talldan
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the first.
What?
Fixes #61565 and possibly also #61582.
The non-iframed editor all instances of
bodywith.editor-styles-wrapperin the editor styles. It also checks for:where(body), but because it was usingreplacewith a string instead of a regex, only the first instance was being replaced.This PR adds a regex with the global flag, so all instances of
:where(body)will be replaced.Testing Instructions