Interactivity API: Move init.js to TypeScript #61723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DAreRodz
commented
May 16, 2024
packages/interactivity/src/init.ts
Outdated
| if ( ! regionRootFragments.has( region ) ) { | ||
| regionRootFragments.set( | ||
| region, | ||
| createRootFragment( region.parentElement, region ) | ||
| createRootFragment( region.parentElement!, region ) |
There was a problem hiding this comment.
I'm not sure if this is a good practice. I guess it would be better to throw an error if region has no parentElement, instead of waiting for the runtime to fail later on. 🤔
There was a problem hiding this comment.
Yes, I think that would be much better. Throw an error. I think this would that the region was html which we don't want.
|
Size Change: +435 B (+0.02%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
May 27, 2024
* Move init.js to typescript * Throw an error for regions without parent Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move
init.jstoinit.ts. I just typed the exported functions and variables.