Editable: Adding a prop to opt-for formatting controls #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
force-pushed
the
add/opt-in-format-controls
branch
from
cdb9fc6
to
e61871c
Compare
mtias
reviewed
May 3, 2017
blocks/components/editable/index.js
Outdated
| @@ -366,7 +366,7 @@ export default class Editable extends wp.element.Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const { tagName: Tag = 'div', style, focus, className, showAlignments = false } = this.props; | |||
| const { tagName: Tag = 'div', style, focus, className, showAlignments = false, formatttingControls } = this.props; | |||
youknowriad
force-pushed
the
add/opt-in-format-controls
branch
from
e61871c
to
b3dab99
Compare
mtias
reviewed
May 3, 2017
| isActive: !! formats[ control.format ] | ||
| } ) ); | ||
|
|
||
| if ( enabledControls.indexOf( 'link' ) !== -1 ) { |
There was a problem hiding this comment.
Why is only link being singled out here?
There was a problem hiding this comment.
Because it has a different behaviour (different onClick and isActive props)
|
Thanks! Looks good to me, though some comments in the code would be good to have. |
youknowriad
force-pushed
the
add/opt-in-format-controls
branch
from
b3dab99
to
e8cac35
Compare
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
formatttingControlsprop to theEditablecomponent to choose which formatting controls to show.Usage:
formattingControls={ [ 'bold', 'italic' ] }