Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows instead of borders on interface skeleton #61835

Merged
merged 4 commits into from
May 29, 2024
Merged

Shadows instead of borders on interface skeleton #61835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ee2445
use shadows instead of borders
richtabor May 21, 2024
feb79df
fix shadow overlap with header
richtabor May 22, 2024
5519af0
transparent outline for high contrast windows
richtabor May 22, 2024
9bbae81
consistent fullscreen mode/site icon
richtabor May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/edit-post/src/components/header/fullscreen-mode-close/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@
background: $gray-900;
color: $white;
border-radius: 0;
height: $header-height + $border-width;
height: $header-height;
width: $header-height;
position: relative;
margin-bottom: - $border-width;

&:active {
color: $white;
Expand Down
4 changes: 1 addition & 3 deletions packages/edit-site/src/components/layout/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,13 @@
position: relative;
color: $white;
border-radius: 0;
height: $header-height + $border-width;
height: $header-height;
width: $header-height;
margin-bottom: - $border-width;
overflow: hidden;
padding: 0;
display: flex;
align-items: center;
justify-content: center;
border-bottom: 1px solid transparent;

&:hover,
&:active {
Expand Down
12 changes: 9 additions & 3 deletions packages/interface/src/components/interface-skeleton/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,26 +125,32 @@ html.interface-interface-skeleton__html-container {
}

.interface-interface-skeleton__sidebar {
border-top: $border-width solid $gray-200;
overflow: hidden;

@include break-medium() {
border-left: $border-width solid $gray-200;
box-shadow: -$border-width $border-width 0 0 rgba($color: #000, $alpha: 0.133); // 0.133 = $gray-200 but with alpha.
outline: 1px solid transparent; // Shown for Windows 10 High Contrast mode.
}
}

.interface-interface-skeleton__secondary-sidebar {
border-top: $border-width solid $gray-200;
right: 0;

@include break-medium() {
border-right: $border-width solid $gray-200;
box-shadow: $border-width $border-width 0 0 rgba($color: #000, $alpha: 0.133); // 0.133 = $gray-200 but with alpha.
outline: 1px solid transparent; // Shown for Windows 10 High Contrast mode.
}
}

.interface-interface-skeleton__header {
flex-shrink: 0;
height: auto; // Keep the height flexible.
border-bottom: $border-width solid $gray-200;
box-shadow: 0 $border-width 0 0 rgba($color: #000, $alpha: 0.133); // 0.133 = $gray-200 but with alpha.
z-index: z-index(".interface-interface-skeleton__header");
color: $gray-900;
outline: 1px solid transparent; // Shown for Windows 10 High Contrast mode.
}

.interface-interface-skeleton__footer {
Expand Down
Loading