Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block variations: Add block-supports flag to add variation specific classname #61864

Open
wants to merge 41 commits into
base: trunk
Choose a base branch
from
Open

Block variations: Add block-supports flag to add variation specific classname #61864

wants to merge 41 commits into from

Commits on Sep 12, 2024

  1. Block Variations: Add block-support for variation-specific classnames

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6fe71ec View commit details
    Browse the repository at this point in the history

  2. Add new helpers

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d42c4d1 View commit details
    Browse the repository at this point in the history

  3. Use new helpers

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1081fe4 View commit details
    Browse the repository at this point in the history

  4. Change attribute from class to className 

    and remove eslint ignore
    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6cd7199 View commit details
    Browse the repository at this point in the history

  5. Fix variation attributes in test

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    608bfd6 View commit details
    Browse the repository at this point in the history

  6. Fix variation attributes in test

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d9036b6 View commit details
    Browse the repository at this point in the history

  7. Fix variation attributes in test

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4de031b View commit details
    Browse the repository at this point in the history

  8. Remove redundant assertion

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b1bd36c View commit details
    Browse the repository at this point in the history

  9. Undo whitespace change

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3cb6023 View commit details
    Browse the repository at this point in the history

  10. Fix test

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e384ec7 View commit details
    Browse the repository at this point in the history

  11. Fix other test

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5dce388 View commit details
    Browse the repository at this point in the history

  12. Fix more variation attributes in test

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e99838e View commit details
    Browse the repository at this point in the history

  13. Remove greedy flag from Regex

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cb9430a View commit details
    Browse the repository at this point in the history

  14. Update comment

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b47cc1f View commit details
    Browse the repository at this point in the history

  15. Change test to make it more easily extensible

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2bde392 View commit details
    Browse the repository at this point in the history

  16. Absorb variation logic into addGeneratedClassName

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1568b02 View commit details
    Browse the repository at this point in the history

  17. Reuse addGeneratedClassName

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    818af29 View commit details
    Browse the repository at this point in the history

  18. Use shorthand

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b34a14e View commit details
    Browse the repository at this point in the history

  19. Simplify test

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8515de7 View commit details
    Browse the repository at this point in the history

  20. More verbose schema descriptions

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2df5db7 View commit details
    Browse the repository at this point in the history

  21. Revert "Reuse addGeneratedClassName" 

    This reverts commit 7011264.
    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d625240 View commit details
    Browse the repository at this point in the history

  22. Replace slash with hyphen

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    faac58c View commit details
    Browse the repository at this point in the history

  23. Add getBlockVariationClassName selector

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c8b9a6a View commit details
    Browse the repository at this point in the history

  24. Use new selector

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2b215d7 View commit details
    Browse the repository at this point in the history

  25. Update docs

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0af2def View commit details
    Browse the repository at this point in the history

  26. Missing comma

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    962a5ae View commit details
    Browse the repository at this point in the history

  27. Add docs

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    173bef2 View commit details
    Browse the repository at this point in the history

  28. Change default to true

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5cccab7 View commit details
    Browse the repository at this point in the history

  29. Fix variation default value in docs

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cff8fcc View commit details
    Browse the repository at this point in the history

  30. typeof classNameSupport === 'boolean' 

    instead of comparing it to `true` or `false`

Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
    @ockham @ntsekouras
    ockham and ntsekouras committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    50a0044 View commit details
    Browse the repository at this point in the history

  31. Backticks 

    Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
    @ockham @ntsekouras
    ockham and ntsekouras committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0d34163 View commit details
    Browse the repository at this point in the history

  32. Bail early

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    aaaa855 View commit details
    Browse the repository at this point in the history

  33. Remove unnecessary export

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e819f54 View commit details
    Browse the repository at this point in the history

  34. Add note that the getBlockDefaultClassName filter also affects variat… 

    …ion class names
    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7cf6f8e View commit details
    Browse the repository at this point in the history

  35. Remove unnecessary check for blockName

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6ad4153 View commit details
    Browse the repository at this point in the history

  36. Add more notes on block default classname filter

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bc3fb00 View commit details
    Browse the repository at this point in the history

  37. Move description before type in schema

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a37f5d3 View commit details
    Browse the repository at this point in the history

  38. toEqual -> toBe 

    Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
    @ockham @gziolo
    ockham and gziolo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    25f7a71 View commit details
    Browse the repository at this point in the history

  39. toEqual -> toBe

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6f016b3 View commit details
    Browse the repository at this point in the history

  40. Use __ instead of - to append variation name

    @ockham
    ockham committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d369a97 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Missed one test

    @ockham
    ockham committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7350ced View commit details
    Browse the repository at this point in the history