Fix broken license check script #61868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Build Tooling
swissspidy
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
6 tasks
|
Flaky tests detected in 0b3ee7d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9193443596
|
|
There are some incompatible licenses reported that need to be further investigated: 
|
|
For reference: gutenberg/packages/scripts/scripts/check-licenses.js Lines 68 to 73 in 8c3a688 Looking at the reported errors and the packages based on
The following ones need more clarification:
|
Maybe they are dependencies of the React Native-related CLI tools that are listed as production dependencies and, therefore, explicitly ignored. |
|
|
|
|
|
@gziolo This seems to be good to go now |
gziolo
approved these changes
Jul 16, 2024
swissspidy
changed the title
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on another PR I realized that the license check script isn't working correctly.
This fixes it.
Why?
Due to early
returnstatements in theforloops, numerous dependencies were not actually checked, which led to the false assumption that all licenses are compatible when they are in fact not.How?
Replace early returns with
continueinsteadAlso fixes some incorrect output when
depis an empty object for instance.Testing Instructions
Run license check, see failing status.
Testing Instructions for Keyboard
Screenshots or screencast