-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Add CSS Custom Properties to CSS types #61872
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in ef75828. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9194100898
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one 👍 I'm fine with keeping it components-only for now, since there doesn't seem to be any relevant usage outside of the package.
Thank you @DaniGuardiola, this has been bugging me for ages 🙌 |
* Augment module. * Add changelog entry. Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
* Augment module. * Add changelog entry. Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Context: #60560 (comment)
Through this augmentation, CSS Custom Properties are supported (type-wise) in the
style
prop of React elements. They need to start with--
. This is only applied to the components package, and could be extended to other packages by just copying the ambient declaration file.