Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Add CSS Custom Properties to CSS types #61872

Merged
merged 2 commits into from
May 22, 2024

Conversation

DaniGuardiola
Copy link
Contributor

@DaniGuardiola DaniGuardiola commented May 22, 2024

Context: #60560 (comment)

Through this augmentation, CSS Custom Properties are supported (type-wise) in the style prop of React elements. They need to start with --. This is only applied to the components package, and could be extended to other packages by just copying the ambient declaration file.

@DaniGuardiola DaniGuardiola requested a review from ajitbohra as a code owner May 22, 2024 15:18
Copy link

github-actions bot commented May 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@DaniGuardiola DaniGuardiola requested review from a team and removed request for ajitbohra May 22, 2024 15:20
@DaniGuardiola DaniGuardiola added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels May 22, 2024
@DaniGuardiola DaniGuardiola requested review from tyxla and mirka May 22, 2024 15:22
Copy link

Flaky tests detected in ef75828.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9194100898
📝 Reported issues:

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one 👍 I'm fine with keeping it components-only for now, since there doesn't seem to be any relevant usage outside of the package.

@DaniGuardiola DaniGuardiola merged commit 22622bf into trunk May 22, 2024
63 checks passed
@DaniGuardiola DaniGuardiola deleted the try/css-custom-properties-types branch May 22, 2024 17:18
@github-actions github-actions bot added this to the Gutenberg 18.5 milestone May 22, 2024
@tyxla
Copy link
Member

tyxla commented May 23, 2024

Thank you @DaniGuardiola, this has been bugging me for ages 🙌

carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jun 4, 2024
* Augment module.

* Add changelog entry.

Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
* Augment module.

* Add changelog entry.

Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants