Editor: Move the resizing of the editor to the EditorCanvas component #61896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
draganescu,
jameskoster,
jasmussen,
ntsekouras and
t-hamano
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
It works, but there's something off with the height and spacing. Site Editor (correct)
Post editor
The canvas is too tall, and the padding is incorrect. |
|
Size Change: +165 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
I think the padding is probably unrelated to this PR but yeah I'm not entirely sure why the height is not the same. I'll try to debug. |
|
Flaky tests detected in caca649. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9209396464
|
|
@jameskoster Would you mind tracking the padding bug separately. I think it exists in trunk already and would be good to add to the 6.6 list. |
youknowriad
force-pushed
the
update/unify-resizeable-editor
branch
from
73a253d
to
5d3b558
Compare
|
Okay. I'm still seeing the height issue though, in fact now it's a bit worse. Seems the canvas fills the available space however large it is: 
|
|
@jameskoster 🤔 I can't reproduce, would you mind doing another test? |
2 tasks
|
Still not working for me. I think it's the inline height style here: 
For some reason it's calculated much too large. Curiously, if I toggle it off in the browser inspector then it gets immediately recalculated and re-added with the correct value 🤔 
|
|
Which theme are you using? |
|
Twenty Twenty-Four |
youknowriad
force-pushed
the
update/unify-resizeable-editor
branch
from
480f10b
to
f801285
Compare
|
Since this is just the post editor and that I'm not able to reproduce. We have two options:
|
|
@ntsekouras or @ellatrix Are you able to reproduce the issue @jameskoster raised above: Opening a template part in focus mode in the post editor makes the height 100% rather than picking the actual height of the template part. |
|
Okay I figured it out. Well, partially. I don't know why, but when I deactivate Jetpack it works as expected. |
jameskoster
approved these changes
May 23, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…WordPress#61896) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…WordPress#61896) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
In the site editor, some entities offer a way to resize the canvas (like template parts and patterns) but in the post editor it's not the case, this PR aligns this behavior by moving the resizing feature to the "editor" package sharing it between both post and site editors.
This involves moving a lot of stuff around so there's a small potential for regressions. Please help test the different entities.
Testing Instructions