Pages data view: Update view icons #62136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -74 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
These icons appear to be using 0.25 pixels, causing aliasing. |
|
It might be worth finding also a "scheduled post" icon, rather than just a calendar. In In principle, all of these are pages, so they would benefit from sharing DNA with the basic "page" icon. Not a blocker, but probably a followup. |
|
I tweaked the draft icons in in the Figma. Also, what do you think about a published pages icon like this:
I agree, with the published pages icon the calendar/time icons stand out a bit much. |
I left a comment in #62138 (comment) to push back on this slightly. I think the icon should communicate the status, not the post type, as the That's not to say that they can't share DNA. I'm just not convinced they need to fit the 'page' footprint. I'll explore some options. |
|
Some of the icons might need tweaking, but I think something like this could work: 
Figma here. |
I don't mind this. I lean towards these draft / pending status icons:
|
|
Please do not reuse the Styles panel icon for drafts or make the pending icon look like a menu button. |
|
I would kindly ask to not use a circle with the horizontal ellipsis. Rationale: in #61909, which originates from a long standing issue, see #42505 and #42555, I proposed to improve the 'more' ellipsis icon to make it more visible for low vision users. One of the identified improvements options is to add a circle around the vertical allipsis, like macOS Finder does. The new circle with the horizontal ellipsis proposed in this PR would clearly conflict with that. Besides the presence of the circle, I would say that having horizontal allipsis and vertical ellipsis icons would be confusing in the first place. Oveerall, to me, the ellipsis doesn't seem appropriate to communicate a 'draft' or 'pending' status. |
afercia
added
the
[Focus] Accessibility (a11y)
afercia
previously requested changes
May 31, 2024
This is the styles icon:
I'm not following. |
What would you suggest for a pending status icon? |
|
For me there's enough difference here: 
That said we could potentially rotate the drafts version to introduce another difference. For the pending icon, off the top of my head I don't think there are any instances of a horizontal ellipsis. Does that alleviate any of the concerns? Here are a couple other options to consider: 
|
@richtabor you're asking to the wrong person 😆 If it was up to me, I wouldn't use icons at all. Rather, I'd consider that when it becomes difficult to identify a glyph that clearly represents a feature, that's probably a sign that a glyph shouldn't be used to start with. In this specific case I'm less concerned because these aren't icon-only controls. There is visible text. The icons only 'complement' the visible text. I see many concepts here that can hardly be represented with icons. Tha makes me think whether there's the real need to What is the value added by icons when they are unclear? A few examples of unclarity:
Overall, I'd think there's way more important things to focus on in the editor UI and I wouldn't spend much effort on a problem that can't be solved. |
|
Overall, in my personal opinion, the real value of icons is when they actually help users to identify a feature or a control. as such, icons should:
I'd like to mention that right now the Icons package contains more than 240 icons. Two hundred forty. Honestly, I think the editor has gone a little too far with icons. |
|
When used consistently, icons help create a cohesive visual language, making interfaces more user-friendly. |
|
I don't mind this direction here:
|
Updated based on this. |
|
Flaky tests detected in 35fb94b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9320155114
|
The rotation helps for me at least, now it does not immediately make me think of the styles sidebar. |
This is obvious. But, I would argue it only works with limited sets of icons. With this PR, the |
|
I like the new icons, but the one for drafts also tipped me off. How about using the last direction but for drafts the circles with the dashed border that was originally for Pending? |
jasmussen
approved these changes
Jun 18, 2024
jameskoster
added
the
Backport to WP 6.7 Beta/RC
|
Merged this so that it is hopefully included in 6.6 🤞 @hanneslsm I don't mind it. Could be worth gathering wider feedback in a separate PR if you have the time / inclination :) |
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: hanneslsm <hanneslsm@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 88e3c93 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: hanneslsm <hanneslsm@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #62021. Update icons for pages data views:
published🆕scheduled🆕drafts(updated icon)pending🆕notAllowed🆕Why?
Currently 'All pages', 'Published', and 'Scheduled' views all use the same icon, which is inconsistent when other views ('Trash' and 'Drafts') use unique icons.