Use preview instead of publishing post in block bindings tests #62235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Code Quality
|
Size Change: +1.85 kB (+0.11%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
artemiomorales
approved these changes
Jun 6, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
You are still creating the posts as drafts and deleting them at the end of the testing. So I'm not sure that this change will affect anything 😅 |
While the functionality is still the same, it's less code, which can make it easier to understand, also less prone to breakage by not relying on utils to click the Save button and dismiss the notice. So I think it's a worthwhile change 😄 |
|
I agree the code looks better. Additionally, I started working on the pull request based on this comment by Ella: "Is there no preview util? This won't work with subdirectory installations, and breaks running tests in MAMP. We should honour the WP_BASE_URL." I should have pointed that out in the description, sorry. Doing it now. |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ress#62235) * Use `openPreviewPage` instead of `publishPost` * Remove unused `BlockBindingsUtils` Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: artemiomorales <artemiosans@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Using the preview functionality instead of publishing a post when checking the frontend in block bindings tests.
Why?
To avoid publishing new posts when it is not needed. As mentioned in this comment, using the current approach "won't work with subdirectory installations, and breaks running tests in MAMP."
How?
Using
openPreviewPageutil instead ofpublishPost. Additionally, it allows us to avoid having a custom util.Testing Instructions
Tests should pass.