Fix unintended overwrite of eslint no-restricted-syntax
#62301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Jun 4, 2024
| @@ -83,6 +83,72 @@ const restrictedImports = [ | |||
| }, | |||
| ]; | |||
|
|
|||
| const restrictedSyntax = [ | |||
There was a problem hiding this comment.
This chunk of code was just extracted. No changes.
| @@ -390,6 +396,7 @@ module.exports = { | |||
| rules: { | |||
| 'no-restricted-syntax': [ | |||
| 'error', | |||
| ...restrictedSyntax, | |||
There was a problem hiding this comment.
We also need to add ...restrictedSyntaxComponents here, but since it will catch a bunch of previously uncaught violations, I'll address this in a separate PR.
There was a problem hiding this comment.
Previously uncaught violation due to the configuration error.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
DaniGuardiola
approved these changes
Jun 4, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…62301) * Fix unintended overwrite of eslint `no-restricted-syntax` * Fix errors in components Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: fullofcaffeine <fullofcaffeine@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the
eslintrcfile so that theno-restricted-syntaxrules are applied as intended.Why?
Any settings for the same rule (
no-restricted-syntaxin this case) will be completely overwritten by subsequentoverridessettings, not merged. I had unconsciously been treating it like they would be merged 🙈How?
Extracted out the restricted syntax rules to be more composable. (This is similar to what had already been done with
restrictedImports.)Testing Instructions
✅ The "global" restricted syntax rules at the root level should also trigger on the following files, as originally intended: