Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Patterns: Disambiguate singular & plural uses of 'Synced' & 'Unsynced' #62375

Merged
merged 6 commits into from
Jun 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIXME: Mark files for possible deletion
  • Loading branch information
mcsf committed Jun 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit efcb984eb12adb34f1e572644cea38e5f27ce74b
Original file line number Diff line number Diff line change
@@ -9,6 +9,10 @@ import { BlockSettingsMenuControls } from '@wordpress/block-editor';
import ReusableBlockConvertButton from './reusable-block-convert-button';
import ReusableBlocksManageButton from './reusable-blocks-manage-button';

/*
* FIXME: CAN WE GET RID OF THIS COMPONENT? AS FAR AS I CAN SEE, IT'S EXPORTED
* BUT NEVER USED, ONLY MENTIONED IN DOCUMENTATION.
*/
export default function ReusableBlocksMenuItems( { rootClientId } ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the whole "reusable-blocks" package can be deprecated. Might be good to do that in its own PR.

Copy link
Contributor Author

@mcsf mcsf Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the whole "reusable-blocks" package can be deprecated. Might be good to do that in its own PR.

Yeah, I added this as a separate commit to easily revert — I just didn't want to forget

return (
<BlockSettingsMenuControls>
Original file line number Diff line number Diff line change
@@ -185,6 +185,12 @@ export default function ReusableBlockConvertButton( {
/>
<ToggleControl
label={ _x( 'Synced', 'pattern (singular)' ) }
/*
* FIXME: See my other FIXME for
* ReusableBlocksMenuItems. If we can get
* rid of that one, can we get rid of this
* one?
*/
help={ __(
'Sync this pattern across multiple locations.'
) }