Build JS module only in development mode #62398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 13, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #36142.
When running
npm run dev, only build the modern module JS and skip building commonJS code.Why?
I don't see much value in building commonJS code in development mode anymore. It seems like every tooling we use only leverages the module code anyway. We still want to keep the commonJS code for production build for now for backward-compatibility.
This should theoretically speed up development build and each incremental builds by 2X.
How?
Add
NODE_ENV=developmentand skip the commonJS code in build.Testing Instructions
npm run devshould still work as expected and only output thebuild-modulefolder for each package.npm run buildshould still build the commonJS code and outputbuildfolder for each package.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A