Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @since tag in docblock in WP_Theme_JSON_Data_Gutenberg. #62425

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

joemcgill
Copy link
Member

What?

The get_theme_json method was actually added in v18.5.0, not 18.3.0. This corrects the docblock reference.

See:

Why?

Corrected by @ryelle in this trac comment: https://core.trac.wordpress.org/ticket/61112#comment:25

The `get_theme_json` method was actually added in v18.5.0, not  18.3.0. This corrects the docblock reference.
@joemcgill joemcgill requested a review from spacedmonkey as a code owner June 7, 2024 19:55
@joemcgill joemcgill requested a review from ryelle June 7, 2024 19:55
Copy link

github-actions bot commented Jun 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joemcgill joemcgill added the [Type] Developer Documentation Documentation for developers label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/class-wp-theme-json-data-gutenberg.php

@joemcgill joemcgill self-assigned this Jun 7, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@joemcgill joemcgill merged commit 57b8b61 into trunk Jun 11, 2024
64 of 69 checks passed
@joemcgill joemcgill deleted the fix/wp-theme-json-data-docblock branch June 11, 2024 16:15
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 11, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
…Press#62425)

The `get_theme_json` method was actually added in v18.5.0, not  18.3.0. This corrects the docblock reference.

Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
Status: Done 😃
Development

Successfully merging this pull request may close these issues.

2 participants