Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed : Disambiguate "Cover" translatable string in the context of background-panel.js #62440

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fixed : Disambiguate "Cover" translatable string in the context of background-panel.js #62440

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
729095e
Fixed : Disambiguate 'Cover' translatable string in the context of ba…
narenin Jun 10, 2024
7746cbf
Added context for Contain and Tile
narenin Jun 10, 2024
2897cbb
Implemented the suggestions
narenin Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/block-editor/src/components/global-styles/background-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
__experimentalHStack as HStack,
__experimentalTruncate as Truncate,
} from '@wordpress/components';
import { __, sprintf } from '@wordpress/i18n';
import { __, _x, sprintf } from '@wordpress/i18n';
import { store as noticesStore } from '@wordpress/notices';
import { getFilename } from '@wordpress/url';
import { useCallback, Platform, useRef } from '@wordpress/element';
Expand Down Expand Up @@ -544,17 +544,17 @@ function BackgroundSizeToolsPanelItem( {
<ToggleGroupControlOption
key="cover"
value="cover"
label={ __( 'Cover' ) }
label={ _x( 'Cover', 'Scale option for dimensions control' ) }
ramonjd marked this conversation as resolved.
Show resolved Hide resolved
/>
<ToggleGroupControlOption
key="contain"
value="contain"
label={ __( 'Contain' ) }
label={ _x( 'Contain', 'Scale option for dimensions control' ) }
ramonjd marked this conversation as resolved.
Show resolved Hide resolved
/>
<ToggleGroupControlOption
key="tile"
value="auto"
label={ __( 'Tile' ) }
label={ _x( 'Tile', 'Scale option for dimensions control' ) }
ramonjd marked this conversation as resolved.
Show resolved Hide resolved
/>
</ToggleGroupControl>
<HStack justify="flex-start" spacing={ 2 } as="span">
Expand Down
Loading