[Mobile] Improve List block onSplit to avoid hiding the keyboard on enter #62446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2024 15:58
…ustom onSplit and onReplace functionality
geriux
added
[Type] Bug
2 tasks
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 2a6c067. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9451758395
|
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…nter (WordPress#62446) * Native RichText - Add __unstableUseSplitSelection prop * Native List block - Use __unstableUseSplitSelection prop and remove custom onSplit and onReplace functionality * Update changelog * Fix changelog after fixing conflict Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org> Co-authored-by: fluiddot <carlosgprim@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #57580
Why?
To avoid hiding and showing the keyboard whenever a new item is added to the list.
How?
In a recent PR #54543 the Web editor unified the split logic of blocks, after some investigation I confirmed using this new functionality solved the issue with the List block.
For now, it only adapts this feature for this block but we should explore enabling this for all blocks as the web editor did.
Testing Instructions
Note
Please use the following builds to test:
Note: Nesting lists make the keyboard hide and show again as the block is recreated.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
iOSListBefore.mov
iOSListAfter.mov