Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React API reference links in @wordpress/element reference-guides #62475

Merged

Conversation

amitraj2203
Copy link
Contributor

What?

Changes React APIs links to point to the updated one.

Why?

The old links go to https://legacy.reactjs.org and shows This content is out of date notice on the site.

Visit https://developer.wordpress.org/block-editor/reference-guides/packages/packages-element/ and try to open any API reference link under Related section. For example: React lazy or React memo

@amitraj2203 amitraj2203 requested a review from ajitbohra as a code owner June 11, 2024 11:20
Copy link

github-actions bot commented Jun 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <amitraj2203@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 added the [Type] Developer Documentation Documentation for developers label Jun 11, 2024
@amitraj2203 amitraj2203 changed the title Update React API reference links Update React API reference links in @wordpress/element reference-guides Jun 11, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This API reference is automatically generated from JSDoc, so we cannot update the Markdown directly.

Could you update the JSDoc of this file, run npm run docs:build, and then commit and push it?

@amitraj2203
Copy link
Contributor Author

@t-hamano Thanks for reviewing the PR. I have addressed the feedback now.

@amitraj2203 amitraj2203 requested a review from t-hamano June 12, 2024 05:42
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit ff0ef2b into WordPress:trunk Jun 12, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 12, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
…es (WordPress#62475)

* Update React API reference links

* Addressed feedback

Co-authored-by: amitraj2203 <amitraj2203@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants