Add support for local keyframes through a PostCSS plugin. #62476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
added
the
[Type] Code Quality
|
Size Change: +27 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e79a8c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9464667362
|
jsnajdr
reviewed
Jun 12, 2024
| @@ -92,7 +92,8 @@ | |||
| "@wordpress/warning": "file:packages/warning", | |||
| "@wordpress/widgets": "file:packages/widgets", | |||
| "@wordpress/wordcount": "file:packages/wordcount", | |||
| "es-module-shims": "^1.8.2" | |||
| "es-module-shims": "^1.8.2", | |||
| "postcss-local-keyframes": "^0.0.2" | |||
There was a problem hiding this comment.
Should it be in devDependencies instead?
jsnajdr
approved these changes
Jun 12, 2024
|
As a follow up, it might make sense to add a stylelint rule to encourage people to localize their keyframes. Or at least a mention in the Coding Guidelines if not. |
tyxla
approved these changes
Jun 13, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…62476) Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add the
postcss-local-keyframesPostCSS plugin (created and maintained by me) to the build pipeline in order to allow keyframe animation names to be local to their stylesheets.Why?
To prevent them from conflicting with other global CSS definitions. See prior attempt here: #61940
How?
Animation names prefixed with
local--will be prepended with a hash on output. Read the linked plugin README above for full examples and docs. The plugin has been added with default options (global scope by default, notably).Testing Instructions
Run the build script (
npm run build) and then look for output CSS files. You can search for.edit-site-sidebar__screen-wrapper.slide-from-leftto quickly find the output of the file modified in this PR for testing purposes. The output file in this case ispackages/edit-site/build-style/posts.css.You should see something like
animation-name: _tpypm_slide-from-left;(note the hash prefix).Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a