Fix: Comments and Pingbacks get cleared out when a pattern is edited. #62507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @mlaetitia. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +32 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jun 18, 2024
jorgefilipecosta
deleted the
fix/xomments-and-pingbacks-get-cleared-out-when-a-pattern-is-edited
branch
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
…#62507) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: marcarmengou <marc4@git.wordpress.org> Co-authored-by: marcarmengou <mlaetitia@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 5906113 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
…#62507) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: marcarmengou <marc4@git.wordpress.org> Co-authored-by: marcarmengou <mlaetitia@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #61827
cc: @mlaetitia
Right now, if meta boxes and custom fields are shown when we save a pattern in a post the comments and pingbacks are disabled. This PR fixes the issue.
The issue happens because when save is pressed and metaboxes/custom fields are enabled we need to trigger a post request saving them and for backwards compatibility comments and pingbacks settings are added in that form.
We were retrieving the comments and pingbacks settings from the current post in the editor. That is wrong the current post may be a pattern that has comments and pingbacks disabled. Instead of using the current post in the editor, we need to retrieve the settings from the post from which meta boxes are being saved, normally the original post opened in the editor.
Testing Instructions
Edit or create a post (Gutenberg)
Make sure you have Custom Fields showing on the editor (hamburguer menu, preferences, advanced , custom fields)
If there's no pattern on that post yet, create one (that syncs across posts)
Make sure the posts and pingbacks are turned on.
Edit the pattern and save it
Head back to the Post editor. If you refresh the page here you'll notice that the comments and pingbacks are turned on ( on trunk they got disabled).