Fix "insert before/after" not showing for blocks in site editor #62530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: +454 B (+0.03%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
I feel like there must be a way. I think it's very difficult to understand the logic, so here's a quick breakdown of what I know it to be:
The two shouldn't be confused, though I know it's very confusing (I left this feedback on the PR that implemented it, but it was ignored). Editable blocks (the block itself) within a pattern will have a |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Yeah, I think you're right! The original condition failed because it's checking the root client id 🤦. I think I fixed it now in ce14a1c. It's indeed very confusing 😅. |
|
Flaky tests detected in ce14a1c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9498345315
|
|
This looks right to me. Sorry it's confusing 😔 To straighten it out we probably need to deprecate both and move to an API design that doesn't rely on encapsulating a bunch of different behaviours into one string. Testing now. |
noisysocks
approved these changes
Jun 14, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…Press#62530) Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> * Fix insert before & after not showing for blocks in templates * Use block editing mode
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> * Fix insert before & after not showing for blocks in templates * Use block editing mode
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> * Fix insert before & after not showing for blocks in templates * Use block editing mode
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: fe9fe31 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> * Fix insert before & after not showing for blocks in templates * Use block editing mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix #62367.
Fix "Insert before" & "Insert after" not showing in the site editor when editing pages.
Why?
The bug was introduced in #61127 (comment). The condition was not enough because it's checking the root client id (parent block).
How?
Move the check to the block settings menu and check the block itself.
Testing Instructions
Screenshots or screencast