Editor: Render editPost slots only in the post editor (same for site editor) #62531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +64 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
The Jetpack plugin does just that, and I can confirm that this patch solves the issue ; slots that are meant for the post editor are no longer displayed in the site editor.
I'd love to see a dev note or a post on the developer blog that would go into more details about the different solutions that will be available to us starting in WordPress 6.6. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3 tasks
Yes, definitely on my todo list. |
|
I just tested with Stackable and Block Visibility.
Block Visibility currently uses: With this PR, the menu item does not display in the Site Editor. I think this approach makes sense. As soon as I update it to: it does display as expected. Overall, I think this is a great PR since it retains the current experience for extenders. Everyone should migrate to 
The last piece of the puzzle will be to document how you can use |
ellatrix
approved these changes
Jun 17, 2024
youknowriad
deleted the
update/render-slots-exclusively-in-desired-contexts
branch
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jun 17, 2024
…editor) (WordPress#62531) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jeherve <jeherve@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org>
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
…editor) (#62531) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jeherve <jeherve@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org>
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
…editor) (#62531) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jeherve <jeherve@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 79c00ca |
ellatrix
added
Backported to WP Core
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
…editor) (#62531) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jeherve <jeherve@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
It seems that some plugins are using the old editPost and editSite slots in the same script files and might also be using these script files in site editor even if they're meant only for post editor (or vice versa). While obviously there are better solutions for these plugin authors to avoid loading the slots and scripts were not needed, this PR tries to mitigate the slots unification effects on this kind of scripts.