Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable reference for getEntityActions action #62536

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ntsekouras
Copy link
Contributor

What?

Small follow up of: #62052 (comment)

Fixes the "The 'useSelect' hook returns different values when called with the same state and parameters. This can lead to unnecessary rerenders. " warning.

Testing instructions

Everything should work as before regarding the post actions

@ntsekouras ntsekouras added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 13, 2024
@ntsekouras ntsekouras self-assigned this Jun 13, 2024
Copy link

github-actions bot commented Jun 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in 703e59a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9497775915
📝 Reported issues:

@ntsekouras ntsekouras merged commit ee30a87 into trunk Jun 13, 2024
66 checks passed
@ntsekouras ntsekouras deleted the use-stable-fallback-ref-getEntityActions branch June 13, 2024 12:02
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 13, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@ellatrix
Copy link
Member

Does this need backporting?

@ntsekouras
Copy link
Contributor Author

Does this need backporting?

@ellatrix no, it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants