Speed up check-build-type-declaration-files #62538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
sirreal
force-pushed
the
fix/faster-declaration-checks
branch
from
9e5ac50 to
b4b1423
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
added
the
[Type] Build Tooling
|
cbravobernal
approved these changes
Jun 13, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Remove npx usage from declaration checking script * Revert "Remove npx usage from declaration checking script" This reverts commit d5a1fe5. * Try skipLibCheck Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: noahtallen <noahtallen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
./bin/packages/check-build-type-declaration-files.jsscript runs onbuild:package-types(and therefore onbuild). It's run very frequently and is pretty slow.This tries two simple strategies to speed it up.
No npx
(Reverted due to unsufficient impact)
npxadds some overhead. Calling thetscbinary directly is faster, but this only saves a couple of ms per run.1.06 ± 0.04 times faster than trunk
trunkbranchskipLibCheck
Our types are compiled without
skipLibCheckenabled, so the libraries we use should be checked. When we run this script, there's so much interdependence between our packages that we're checking out own package types over and over and we checking all of our libraries again. We should be able to enableskipLibCheckand save some time, the lib check is the point of this script itself.If there were problems in our packages, without
skipLibCheckenabled we'd see the same problems over and over for the packages themselves and for every dependent package.3.15 ± 0.12 times faster than trunk
trunkbranchTesting Instructions
node ./bin/packages/check-build-type-declaration-files.jsshould be faster on this branch than on trunk.Future
This should be a good candidate for parallelization with something likeworker-farmfor bigger gains.