Fix: Flakey deferred store test #62571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
approved these changes
Jun 14, 2024
sirreal
force-pushed
the
fix/59899-flaky-test-deferred-store
branch
from
8a10637 to
3bfb495
Compare
|
Flaky tests detected in 3bfb495. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9516600659
|
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Use events to proceed test when ready * Initialize once on the event * Use window not globalThis in test * Fix event dispatch in page Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix flakey test #59899.
This is an improvement on #61359.
Closes #59899.
How?
Instead of setting an arbitrary timeout that's long enough, we'll initialize the store when a custom event fires. We can dispatch that even when we're ready for tests to proceed.
Testing Instructions
CI passes.