-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit site: Do not autoformat edit-site/lib #62573
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Related: #53653 |
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
0799898
to
403b1dc
Compare
Flaky tests detected in 403b1dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9516619862
|
f07b7fd
to
a223b55
Compare
What?
Disable and revert autoformatting for
edit-site/lib
vendored files. These appear to be compiled external files that should not be auto-formatted.Why?
In #62572 I noticed some suspicious files being autoformatted so investigated. It seems that these files were autoformatted in #54458 (see this comment) so I reverted that autoformatting as well. According to git, that was the last change to the
edit-site/lib
directory so I restored the directory to it's state prior to that commit withgit checkout b06240a7ce93caf3d1c410267634b3d3d6d5a514~ -- packages/edit-site/lib
.This also adds a git attribute to indicate that the directory contains vendored code. This should improve GitHub statistics for the project.
Testing Instructions
npm run format
does not format anything inpackages/edit-site/lib
(on trunk it would).