-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct documentation for WP_Block_Parser_Frame class #62598
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @dilipbheda! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! I left a note because I think it would be good to add the additional Optional.
note in the parameter descriptions, but otherwise this can be quick and easy. 😄
packages/block-serialization-default-parser/class-wp-block-parser-frame.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you'll need to rebase this or run the tests again, but I think they aren't related to your change.
Once they pass this looks ready to go. Thanks again!
@dmsnell Now all tests are passed, I'm not sure about the |
@dilipbheda if you click on the "Details" link for that failing test it gives you instructions for creating a PR or a change to ensure that this propagates upward into Core. You might search for a similar ticket with "Backport" in the name. See what you can do; if we need help we can reach out to someone more familiar with that process. |
@dmsnell Now passed |
See https://core.trac.wordpress.org/ticket/60423 Core ticket for more details.