Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation for WP_Block_Parser_Frame class #62598

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

dilipbheda
Copy link
Contributor

See https://core.trac.wordpress.org/ticket/60423 Core ticket for more details.

@dilipbheda dilipbheda requested a review from dmsnell as a code owner June 15, 2024 14:53
Copy link

github-actions bot commented Jun 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dilipbheda <dilipbheda@git.wordpress.org>
Co-authored-by: dmsnell <dmsnell@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 15, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @dilipbheda! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jun 15, 2024
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I left a note because I think it would be good to add the additional Optional. note in the parameter descriptions, but otherwise this can be quick and easy. 😄

Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to rebase this or run the tests again, but I think they aren't related to your change.

Once they pass this looks ready to go. Thanks again!

@dilipbheda
Copy link
Contributor Author

Looks like you'll need to rebase this or run the tests again, but I think they aren't related to your change.

Once they pass this looks ready to go. Thanks again!

@dmsnell Now all tests are passed, I'm not sure about the Verify Core Backport Changlog / Check CHANGELOG diff checklist. Should I open a new PR for WordPress/develop a repo with the same changes?

@dmsnell
Copy link
Member

dmsnell commented Jun 17, 2024

@dilipbheda if you click on the "Details" link for that failing test it gives you instructions for creating a PR or a change to ensure that this propagates upward into Core. You might search for a similar ticket with "Backport" in the name. See what you can do; if we need help we can reach out to someone more familiar with that process.

@dilipbheda
Copy link
Contributor Author

@dmsnell Now passed Verify Core Backport Changlog / Check CHANGELOG diff checklist as well.

@akasunil akasunil merged commit 2f5c7c0 into WordPress:trunk Jun 19, 2024
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants