-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github PHP changes workflow: remove it #62609
Conversation
Looks good to me unless anyone in @WordPress/gutenberg-core has any objections 👍 |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, thanks for the cleanup!
No objections, if you think the failing test is enough. I was wondering if the backport log test should leave an actual Github comment instead, though there should be a clear error message if you open the test results. |
…k backport changelog workflow is in place.
a84af57
to
c5bd1de
Compare
Flaky tests detected in c5bd1de. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9543945900
|
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Removing the PHP changes workflow
Why?
The PHP detections action checks for PHP changes and adds a comment to ask whether a backport is necessary.
Example:
I think it's just noise now that the check backport changelog workflow is in place.
Also to reduce clutter.