Performance: run block variation hook only for matches #62617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I have an additional performance concern here: #57908 (comment) |
|
Size Change: +66 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 632a31c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9546382055
|
aaronrobertshaw
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Nice work! Thanks for putting this together @ellatrix 🙇
✅ Approach looks good
✅ Variations are applied correctly in post/site editors
✅ Variations are saved and applied on the frontend still too
Screen.Recording.2024-06-18.at.12.51.41.PM.mp4
ellatrix
added
the
Backport to WP 6.7 Beta/RC
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 2bb7aa6 |
ellatrix
added
Backported to WP Core
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #57908.
Adds an
isMatchfunction so we can avoid running the block variation hook when a blocks has class names (which is common), but there are no variation class names. Additionally, avoid the backtracking regex.Why?
Performance.
How?
With an
isMatchfunction.Testing Instructions
See things to test in #57908, everything should work correctly.
Testing Instructions for Keyboard
Screenshots or screencast