-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: block style variations: only calc styles for present inner blocks #62683
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
35d4221
to
eba914c
Compare
Size Change: +79 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Flaky tests detected in eba914c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9592379067
|
What?
Currently we generate styles for all block types when a block has a variation. This PR attempts to limit generating styles only for blocks types that are nested within the block.
Why?
Performance.
How?
Testing Instructions
See things to test in #57908, everything should work correctly.
Testing Instructions for Keyboard
Screenshots or screencast