Inspector: Improve handling of long words in post titles #62691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Bug
ellatrix
approved these changes
Jun 20, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0384b0e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9594804610
|
|
@jameskoster thanks for looking into this. How about avoiding hyphenating also in the card title? |
|
@afercia Is there any reason to avoid it? In this case it seems grammatically appropriate and should aid readability. |
For a few reasons: 1 2 Chrome
Firefox
Safari
Given the inconsistent behavior, I'm not sure we can assume hyphenation in browsers is reliable. 3 |
|
I don't necessarily agree that the third point is a problem, but the others are good arguments. I'll push an update. |
|
This needs to be merged ASAP if you want to include it in RC1 |
|
The failing tests seem unrelated to this PR. I've rebased which will hopefully fix, otherwise would it be an option to force merge? I'll leave that decision to you @ellatrix. |
|
A rebase should fix it yes, please let's avoid force merging |
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 528122e |
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62627.
What?
Improves handling of long words in the UI. Specifically:
Before
before.mp4
After
How?
hyphens: autois used to hyphenate long words.word-break: break-wordis used to break long words without hyphenating. This is to avoid confusion about the slug structure.Testing Instructions