-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Fix blocked Post Publish Panel buttons on mobile #62736
Editor: Fix blocked Post Publish Panel buttons on mobile #62736
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ivan-ottinger! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Side thought: we definitely lack e2e tests on mobile, we should probably consider writing some of these to avoid similar regressions in the future. |
#62736) Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 49cfe51 |
#62736) Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Thank you, Ella. |
What?
Fixes #62738.
There's a small regression introduced by #62237 where on mobile viewport, the
Publish
andCancel
buttons are not visible.Why?
Without the fix, the
Publish
andCancel
buttons are not visible.How?
By setting
.editor-post-publish-panel
'stop
property to$admin-bar-height-big
- as it used to beTesting Instructions
Publish
button.Publish
andCancel
buttons should be visible.Testing Instructions for Keyboard
N/A
Screenshots or screencast
Shared above.