Rich Text: Deprecate event proxying #6286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to deprecate the
RichText
component'sproxyPropEvents
function, which handles and propagates a full set of events bound to TinyMCE.There are a few motivations for this change:
mousemove
forRichText
.onChange
have transforms applied in addition to the default event handling, and don't passevent
as a callback argument.This was originally introduced in the very first implementation of the autocompleter (#2630), where the autocompleter had applied props directly to the instance of
RichText
. This was refactored away in #2896.Many alternatives exist, and are included in the deprecation message:
onSetup
and binding events directly to the internal editor instanceNote: This is not expected to have an impact on the majority usage of
RichText
. TheonChange
callback still behaves as it did previously.Testing instructions:
Verify there are no regressions in the behavior of
RichText
.Try adding an event like
onContextMenu
to aRichText
element and verify that a deprecation warning occurs.