DataViews: make view.hiddenFields optional
#62876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
|
Size Change: +6 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
oandregal
requested review from
ntsekouras,
youknowriad,
ellatrix and
jorgefilipecosta
youknowriad
reviewed
Jun 26, 2024
| @@ -216,7 +216,7 @@ interface ViewBase { | |||
| /** | |||
| * The hidden fields. | |||
| */ | |||
| hiddenFields: string[]; | |||
| hiddenFields?: string[]; | |||
There was a problem hiding this comment.
I've been reading our types lately and this one actually stood out to me :P
I think it makes more sense to have "visibleFields" rather than "hiddenFields" as we move forward. I'm pretty sure most entities will have a lot more fields that what we currently have and an allow list would be better.
Omitting it could have the same effect as today when you omit hiddenFields.
Not a concern for this PR though, just a thought that I had.
There was a problem hiding this comment.
Yeah, that's a good point: post types have a lot of metadata and if we aim to share the field definition between a view and a form (e.g.: details panel), a lot of the fields would be hidden in the view.
youknowriad
reviewed
Jun 26, 2024
andrewserong
added
the
[Feature] DataViews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes the
view.hiddenFieldsconfig optional.Why?
It should not be required to provide an empty
hiddenFieldsarray it the consumer doesn't have any hidden fields.How?
hiddenFieldstype to optional.visibleFields.DEFAULT_VIEWconfig.Testing Instructions
Visit "Site Editor > Patterns" and verify everything works as expected.
Before this PR, if the
hiddenFieldsproperty was removed from here (468c294) the Patterns page would not load.