Fix extra scrollbar when a popover extends past the viewport. #62894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
tellthemachines
requested review from
noisysocks,
jasmussen,
ramonjd and
andrewserong
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
37 tasks
|
Size Change: -5 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jun 27, 2024
talldan
approved these changes
Jun 27, 2024
|
Flaky tests detected in 81c8f6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9691034490
|
talldan
added
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 27, 2024
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: e238081 |
github-actions
bot
added
the
Backported to WP Core
This was referenced Jun 27, 2024
|
Nice! |
andrewserong
added
the
[Feature] UI Components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When an active popover inside
interface-skeleton__contentextends vertically past the viewport, an extra scrollbar appears on trunk. This can be reproduced with the following steps:The overflow rule being changed here has been around for a long time so I want to make sure this change doesn't break anything else 😅
My testing shows everything working correctly: both editor canvas and sidebar are still scrollable and look as expected. I think the overflow may have been set to auto to unset its default
visible, because when setting it tovisiblethings do look a bit funny. If that's the extent of what the overflow is doing, this change should be safe enough.Before:
After: