Block supports: ensure tools panel dropdown are visible on mobile #62896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that returns different popover props depending on the viewport width
ramonjd
added
[Type] Bug
ramonjd
requested review from
ellatrix,
artemiomorales,
michalczaplinski and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +92 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 27c2443. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9690027885
|
talldan
approved these changes
Jun 27, 2024
Thanks for testing @talldan I guess it's worth a shot. I'll add the label. I imagine it's been in WordPress 6.4-6.5... or since, at the earliest, Dec 19, 2023, when the original Gutenberg PR was merged. |
ramonjd
added
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 27, 2024
…2896) * Remove the const `TOOLSPANEL_DROPDOWNMENU_PROPS` in favour of a hook that returns different popover props depending on the viewport width * Remove offset completely * Add to block support panels * Replace in block library. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 5640c95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensures Tools Panel dropdowns in mobile view appear on-screen.
They're currently positioned to the left of the sidebar in desktop since #55785
Why?
Because of a large offset value, Tools Panel dropdowns in mobile view appear off-screen.
How?
Remove the const
TOOLSPANEL_DROPDOWNMENU_PROPSin favour of a hook that returns different popover props depending on the viewport width.Testing Instructions
See #55785, which introduced the constant, to ensure there are no regressions.
This PR also updates the Image and Query blocks in the block library, check the Tools Panels for both these as well (please 😄 )
Screenshots or screencast
Desktop (no regressions)