Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call tinyMCE save before sending metabox data #6293

Closed
wants to merge 13 commits into from

Conversation

davisshaver
Copy link
Contributor

Description

Updates #3840 to include window.tinyMCE.triggerSave() prior to metabox serialization.

How has this been tested?

Locally.

@aduth
Copy link
Member

aduth commented Apr 19, 2018

What is the context for this?

@davisshaver
Copy link
Contributor Author

@aduth Follows up #3840 to update the input field controlled by WP editor instances on the page before sending metadata params. There was a discussion on there that I didn't totally follow but I wanted to share my patch for making the TinyMCE fields work as expected.

@danielbachhuber
Copy link
Member

@davisshaver Is this supposed to be changing the TinyMCE version too?

@davisshaver
Copy link
Contributor Author

@danielbachhuber Yes, it is – I originally approached as continuation of #3840, but as you'll see in #3840 (comment) @youknowriad ultimately suggested we fix another way in Core.

@danielbachhuber
Copy link
Member

This PR is a bit garbled, so I've opened a new issue to track this to resolution #7176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants