Tabs: split animation logic into multiple separate composable utilities. #62942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
added
the
[Type] Code Quality
ciampo
approved these changes
Jun 28, 2024
|
@ciampo thx for the review, I'll add a changelog entry for the whole thing in the last PR, since this is really step 1 of 3 of the same task (refactor ToggleGroupControl to use the same animation logic as Tabs) 👍 |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I organized and documented these.
Why?
In a follow-up, I'm gonna move them to a shared file where they'll be used in other components (first one will be
ToggleGroupControl.How?
Make each utility do a single thing really well, document everything, ensure nice minimal APIs and types.
Testing Instructions
Tabs should still work properly, can check the storybook stories or places with tabs in Gutenberg.
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a