Ensure disable overrides button is active for image blocks with captions or links #62948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I considered whether this one should be backported. I think it should. Even though only plugin/beta users will be able to reproduce, plugin users might decide to deactivate the plugin, and I think core should still be able to handle this case. |
|
Size Change: +4 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Jun 28, 2024
talldan
changed the title
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 28, 2024
…tions or links (#62948) Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: b9db3e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #62747, the 'Enable Overrides' button was disabled for image blocks with captions or links within patterns, as they're not supported:
The code for this change also incorrectly applies the same treatment to the 'Disable overrides' version of the button when such a block already has overrides (a user would've been able to add these in the gutenberg plugin or WP6.6 beta before that PR was merged):
These users should still be able to remove overrides.
How?
Makes a small adjustment to the conditions for the button to also check the
hasOverridesvariable.Testing Instructions