Components: Fix the 'useUpdateEffect' hook in strict mode #62974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +14 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
requested review from
mirka,
talldan,
tyxla and
andrewserong
and removed request for
ajitbohra
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Nice detective work @Mamaduka, thanks for following up!
✅ The widgets editor in the customizer no longer scrolls away when interacting with blocks
✅ The focal point picker is working for the Cover block and background image block support in the post and site editors
✅ Did a quick smoke check of other design tools, etc to make sure nothing else seems to break
LGTM! 🚀
Looks like there's a small conflict in the changelog that'll need to be resolved before merge.
|
Thanks @Mamaduka, this tests well for me too. |
Mamaduka
force-pushed
the
fix/widgets-customizer-strict-mode
branch
from
f75f360 to
d566494
Compare
|
Nice, thanks @Mamaduka 🙌 |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…62974) * Components: Fix the 'useUpdateEffect' hook in strict mode * Add changelong entry Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes the
useUpdateEffecthook to avoid running effects on the mount when the strict mode is enabled.Fixes: #62898.
Fixes: a bug in
FocalPointPickerdisplaying a grid overlay on the mount. It should only be visible when changing the values.Why?
The hook didn't account for the extra run in strict mode.
Note: The hook is used by the panel body component and handles "scroll-into-view" after the initial render. The bug was only visible in the Customize > Widgets editor.
gutenberg/packages/components/src/panel/body.tsx
Lines 62 to 80 in 237e09d
How?
Sync the fix from the Ariakit library - packages/ariakit-utils/src/hooks.ts
Testing Instructions
Customize Widgets
Focal Pointer
Testing Instructions for Keyboard
Sames
Screenshots or screencast
CleanShot.2024-06-28.at.17.06.17.mp4